SplashOutputDev: Fix integer overflow in tilingPatternFill

Origin: https://gitlab.freedesktop.org/poppler/poppler/-/commit/8352264766652b98336e92359a70b3161a9ab97a
Bug-Debian: https://bugs.debian.org/1138708
Bug: https://gitlab.freedesktop.org/poppler/poppler/-/work_items/1715
Bug-Debian-Security: https://security-tracker.debian.org/tracker/CVE-2026-10118

Use checkedMultiply() to check integer multiplication of surface size
and number of repetitions to avoid integer overflow and possible memory issues.

Fixes: #1715
Gbp-Pq: Name SplashOutputDev-Fix-integer-overflow-in-tilingPatter.patch

diff --git a/poppler/SplashOutputDev.cc b/poppler/SplashOutputDev.cc
index e26e36229bb2a529ea651cd23cc67eabc717b41d..7a32cc9e222a2714d04d41856a74f9af6b81795a 100644 (file)
--- a/poppler/SplashOutputDev.cc
+++ b/poppler/SplashOutputDev.cc
@@ -4345,7 +4345,7 @@ bool SplashOutputDev::tilingPatternFill(GfxState *state, Gfx *gfxA, Catalog *cat
     matc[2] = ctm[2];
     matc[3] = ctm[3];
 
-    if (surface_width == 0 || surface_height == 0 || repeatX * repeatY <= 4) {
+    if (surface_width == 0 || surface_height == 0 || repeatX * repeatY <= 4 || checkedMultiply(surface_width, repeatX, &result_width) || checkedMultiply(surface_height, repeatY, &result_height)) {
         state->setCTM(savedCTM[0], savedCTM[1], savedCTM[2], savedCTM[3], savedCTM[4], savedCTM[5]);
         return false;
     }
@@ -4367,8 +4367,6 @@ bool SplashOutputDev::tilingPatternFill(GfxState *state, Gfx *gfxA, Catalog *cat
         kx = matc[0];
         ky = matc[3] - (matc[1] * matc[2]) / matc[0];
     }
-    result_width = surface_width * repeatX;
-    result_height = surface_height * repeatY;
     kx = result_width / (fabs(kx) + 1);
     ky = result_height / (fabs(ky) + 1);
     state->concatCTM(kx, 0, 0, ky, 0, 0);